-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix icons + locale #20213
[docs] Fix icons + locale #20213
Conversation
Details of bundle changes.Comparing: 27471b4...482e5f8 Details of page changes
|
8eb9e1b
to
482e5f8
Compare
This might have increased memory usage which is a problem for netlify deploys |
It was my main fear. Have you noticed elements that might suggest it has? I'm happy to update to a different approach. I wish we could measure memory usage 🤔. |
Some of the recent PRs failed on netlify. I haven't observed that prior to this PR. |
Let's monitor it closely, at least, we have a good suspected origin |
Added |
It seems that the performance issue with
require.context
was solved during the Next v8 to v9 upgrade. It takes 36s on my machine between these two methods. I hope it's not just that I have a x2 better machine now. Let's see how Netlify handles it.Solve (requested by @DDDDDanica):